[GUI] Prevent invalid dashboard txs list filter value loaded from settings #2173
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nknown values. Preventing any possible not expected `transactionType` value stored that doesn't map with any available filter.
Fuzzbawls
approved these changes
Jan 30, 2021
There was a problem hiding this comment.
Should be good enough for the most common cause of this issue. In rare circumstances I have seen the settings cache be set at some insane int value (ex: 3854851), but don't remember the exact circumstances that caused it.
If this remains an issue after this PR, we could enumerate the valid values and verify that the current cached setting is within that valid range, but might be overkill for now, so...
utACK a3eea8c
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard against any not expected
transactionTypevalue retrieved from the setting that doesn't map to any available filter type.Can be tested changing the value manually inside the settings file and starting the wallet again, the tx filter type combobox will be shown empty without this fix.